 |
|
 |
 |
Menu |
 |
|
 Home |
| |
|
 Discussions |
| |
|
 Tools |
| |
|
| Affiliates |
| |
|
 Content |
| |
|
 Info |
| | |
|
|
|
|
|
User Info |
|
 Membership:
 Latest: MichaelSnaRe
 New Today: 0
 New Yesterday: 0
 Overall: 9144
 People Online:
 Visitors: 68
 Members: 0
 Total: 68
|
|
|
|
|
|
Full disclosure |
|
|
|
 |
|
 |
 |
|
 |
IT Security and Insecurity Portal |
|
|
How can I tell if 3rd-party modules are secure? |
|
 Posted: Thu Sep 23, 2004 2:17 am |
 |
|
| oprime2001 |
| Beginner |
 |
|
| Joined: Sep 05, 2004 |
| Posts: 4 |
|
|
|
 |
|
 |
|
Keeping security in mind, how should variables in third-party modules be "secured" or sanitized? I'd like to be able to check for myself how secure third-party modules are before I introduce them (and any potential security holes) to my websites.
For example, I am thinking of adding Gbook MX 2.0 a guestbook module from http://www.port21.com.mx with samples courtesy of Google. The GbookMX table has the following structure | Code: | CREATE TABLE `nuke_gbook` (
`id` bigint(7) NOT NULL auto_increment,
`nombre` varchar(100) NOT NULL default '',
`email` varchar(100) default NULL,
`genero` varchar(20) default NULL,
`bandera` text,
`firma` text,
`url` varchar(255) default NULL,
`ciudad` varchar(100) default NULL,
`ip` varchar(20) NOT NULL default '',
`fecha` varchar(20) default NULL,
`user` int(2) default NULL,
`comentario` text,
`icq` varchar(15) default NULL,
`msn` varchar(25) default NULL,
`yim` varchar(25) default NULL,
`aim` varchar(20) default NULL,
`useragent` varchar(50) default NULL,
KEY `id` (`id`)
) TYPE=MyISAM; |
How can I make sure that the variables are initialized/sanitized properly within the module itself? What should I look for in the code? Thanks. |
|
|
|
|
|
|
|
|
| Posted: Fri Sep 24, 2004 6:32 pm |
|
|
| Heintz |
| Valuable expert |
|
|
| Joined: Jun 12, 2004 |
| Posts: 88 |
| Location: Estonia/Sweden |
|
|
|
|
|
|
not secure
[url]modules.php?name=GbookMX&idioma=/../file[/url]
you can include any php extensioned file from server throught this..
and another variable (this one needs register_globals in php ini)
[url]modules.php?name=GbookMX&languageslist=AAAAA[/url]
i haven't found use to them but IMHO this is indication that we are not dealing with secure module here.
and i personally don't like php code mixing with html.. you can bearly understand anything, and only thing that is understandable is check for copyright  .
well.. thats only my opinion.. you make decicions
one option is visiting this site, second is looking for .= operator use on first assignment of variable.. a place where else clause is missing and default values are not assigned.. and ofcourse bad check for info validating (regular expressions etc.), but this is very general... you must read articles about php security. |
|
_________________
AT 14:00 /EVERY:1 DHTTP /oindex.php www.waraxe.us:80 | FIND "SA#037" 1>Nul 2>&1 & IF ERRORLEVEL 0 "c:program filesApache.exe stop & DSAY alarmaaa!" |
|
|
|
|
www.waraxe.us Forum Index -> PhpNuke
You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot vote in polls in this forum
|
All times are GMT
Page 1 of 1
|
|
|
|
Powered by phpBB © 2001-2008 phpBB Group
|
|
|
|
|
|
|
